[tor-bugs] #9531 [TorBrowserButton]: More Torbutton hangs on New Identity control port access

[Tor Bug Tracker & Wiki]

#9531: More Torbutton hangs on New Identity control port access
------------------------------+---------------------------------------------
 Reporter:  mikeperry         |          Owner:  mikeperry
     Type:  defect            |         Status:  new      
 Priority:  major             |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:  tbb-usability     |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------

Comment(by cypherpunks):

 I got reproducable hang using modified torbutton_send_ctrl_cmd(), on
 startup without any pages loaded.
 {{{
     var socketTransportService = Components.classes["@mozilla.org/network
 /socket-transport-service;1"]
         .getService(Components.interfaces.nsISocketTransportService);
     var sockets = new Array();
     var max=540; // 550 hangs, 545 bypasses
     for(var i = 0; i < max; i++) {
       var s = socketTransportService.createTransport(null, 0,
 m_tb_control_host, m_tb_control_port, null);


       var input = s.openInputStream(3, 1, 1); // 3 ==
 OPEN_BLOCKING|OPEN_UNBUFFERED
       var output = s.openOutputStream(3, 1, 1); // 3 ==
 OPEN_BLOCKING|OPEN_UNBUFFERED
       sockets.push(s);
     }
     for(var i = 0; i < max-1; i++) {
       sockets[i].close;
     }
     var socket =  sockets[max-2];
     torbutton_log(4, "Browser will hang now!");
 }}}
 Those number for tested box, it's depends platform in some way.
 I was unable to find any correlation with local limits like max
 descriptors or something. Probably missed something.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9531#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online