[tor-bugs] #9507 [HTTPS Everywhere: Chrome]: Infinite loops in HTTPS Everywhere 2013.8.16 for Chrome (was: Releasing HTTPS Everywhere 2013.8.16 from the master branch seems to break Chrome)

[Tor Bug Tracker & Wiki]

#9507: Infinite loops in HTTPS Everywhere 2013.8.16 for Chrome
-----------------------------------------+----------------------------------
    Reporter:  pde                       |       Owner:  pde   
        Type:  defect                    |      Status:  closed
    Priority:  blocker                   |   Milestone:        
   Component:  HTTPS Everywhere: Chrome  |     Version:        
  Resolution:  fixed                     |    Keywords:        
      Parent:                            |      Points:        
Actualpoints:                            |  
-----------------------------------------+----------------------------------
Changes (by pde):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 backflash, the bug was triggered by accidentally releasing from the git
 master rather than stable branch.  Which doesn't explain why the bug was
 only visible in the master branch, because I think it's in stable too.
 Probably, there were just larger numbers of rulesets and exclusions in
 master, which exposed the loop variable clobbering problem that you found.
 Also, [https://gitweb.torproject.org/https-
 everywhere.git/commitdiff/975f03c86e76bc38dcc4d9a8a909ee671976090d this
 patch] was in stable but not in master, and it caused many rulesets to be
 checked twice on a given request (in fact you can see that happening in
 the logs that realityexists pasted above.

 I'm going to apply your patch to stable and master.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9507#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online