[tor-bugs] #9462 [BridgeDB]: BridgeDB does some strange things when parsing bridge descriptors

[Tor Bug Tracker & Wiki]

#9462: BridgeDB does some strange things when parsing bridge descriptors
-------------------------+--------------------------------------------------
 Reporter:  isis         |          Owner:  isis    
     Type:  defect       |         Status:  accepted
 Priority:  normal       |      Milestone:          
Component:  BridgeDB     |        Version:          
 Keywords:  descriptors  |         Parent:          
   Points:               |   Actualpoints:          
-------------------------+--------------------------------------------------
Changes (by isis):

 * cc: isis@… (added)
  * status:  new => accepted


Comment:

 The first one was fixed here:

 {{{
 * commit b5ebab54369de950339a9fa2ff3483ebff32e4f8 (HEAD, tpo-isis/fix
 /9462A-keyid-equals-fingerprint
 | gpg: Signature made Mon 12 Aug 2013 21:58:28 UTC
 gpg:                using RSA key A3ADB67A2CDB8B35
 gpg: Good signature from "Isis! <isis at patternsinthevoid.net>" [ultimate]
 gpg:                 aka "Isis <isis at leap.se>" [ultimate]
 gpg:                 aka "Isis <isis at torproject.org>" [ultimate]
 gpg:                 aka "Isis! <isis at riseup.net>" [ultimate]
 gpg: Signature notation:
 isis at patternsinthevoid.net=0A6A58A14B5946ABDE18E207A3ADB67A2CDB8B35
 gpg: Signature expires Tue 12 Aug 2014 21:58:28 UTC
 Author:     Isis Lovecruft <isis at torproject.org>
 | AuthorDate: 2 minutes ago
 | Commit:     Isis Lovecruft <isis at torproject.org>
 | CommitDate: 2 minutes ago
 |
 |     Fix prepending of "keyid=" string to PT bridge fingerprints.
 | ---
 |  lib/bridgedb/Bridges.py | 3 +--
 |  1 file changed, 1 insertion(+), 2 deletions(-)
 |
 | diff --git a/lib/bridgedb/Bridges.py b/lib/bridgedb/Bridges.py
 | index 9fc94e8..846bb77 100644
 | --- a/lib/bridgedb/Bridges.py
 | +++ b/lib/bridgedb/Bridges.py
 | @@ -465,8 +465,7 @@ class PluggableTransport:
 |              address = "[%s]" % self.address
 |          else: address = self.address
 |          host = "%s %s:%d" % (self.methodname, address, self.port)
 | -        fp = ''
 | -        if includeFingerprint: fp = "keyid=%s" %
 self.bridge.fingerprint
 | +        fp = str(self.bridge.fingerprint) if includeFingerprint else ''
 |          args = " ".join(["%s=%s"%(k,v) for k,v in
 self.argdict.items()]).strip()
 |          return "%s %s %s" % (host, fp, args)
 |
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9462#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online