[tor-bugs] #9454 [TorBrowserButton]: Torbrowser shouldn't load any plugins if user didn't changed security settings

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 12 07:10:21 UTC 2013


#9454: Torbrowser shouldn't load any plugins if user didn't changed security
settings
------------------------------+---------------------------------------------
 Reporter:  cypherpunks       |          Owner:  mikeperry
     Type:  defect            |         Status:  new      
 Priority:  normal            |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:                    |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------

Comment(by cypherpunks):

 Proposed fix includes changes to Torbutton code.
 {{{
 --- torbutton.origin.js
 +++ torbutton.js
 @@ -1523,12 +1523,7 @@
  // toggles plugins: true for disabled, false for enabled
  function torbutton_toggle_plugins(disable_plugins) {
    if (m_tb_tbb) {
 -    var PH=Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost);
 -    var P=PH.getPluginTags({});
 -    for(var i=0; i<P.length; i++) {
 -        if (P[i].disabled != disable_plugins)
 -          P[i].disabled=disable_plugins;
 -    }
 +    m_tb_prefs.setBoolPref("plugin.disable", disable_plugins);
    }
  }
 }}}

 "plugin.disable" must be true by default.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9454#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list