[tor-bugs] #9400 [Tor]: double-close in socketpair replacement function on failure

[Tor Bug Tracker & Wiki]

#9400: double-close in socketpair replacement function on failure
------------------------------------+---------------------------------------
 Reporter:  nickm                   |          Owner:                    
     Type:  defect                  |         Status:  new               
 Priority:  minor                   |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                     |        Version:                    
 Keywords:  tor-relay 024-backport  |         Parent:                    
   Points:                          |   Actualpoints:                    
------------------------------------+---------------------------------------
 Our socketpair replacement function (only used on Windows), in its clean-
 up-on-failure code, potentially does a double-close of the listener
 socket.  Additionally, it doesn't use the right macros for invalid
 sockets.

 Found by coverity.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9400>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online