[tor-bugs] #8800 [Flashproxy]: Make facilitator public key configurable

[Tor Bug Tracker & Wiki]

#8800: Make facilitator public key configurable
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  dcf           
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Flashproxy   |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by dcf):

  * status:  needs_review => needs_revision


Comment:

 Thanks for the quick patches.
 {{{
 -    options.facilitator_publickey_pem = a
 +    options.facilitator_publickey_pem = open(a, "r").read()
 }}}
 I don't like this. Better to have the global option be called
 `options.facilitator_pubkey_filename` with a default value of `None`. Then
 provide an abstraction `get_facilitator_pubkey`. `get_facilitator_pubkey`
 checks the value of `options.facilitator_pubkey_filename`. If the file
 name is `None`, it return the result of calling
 [http://www.heikkitoivonen.net/m2crypto/api/M2Crypto.RSA-
 module.html#load_pub_key_bio RSA.load_pub_key_bio] on a memory buffer
 containing `DEFAULT_FACILITATOR_PUBKEY_PEM`, as is done now. If the file
 name is not `None`, it returns the result of calling
 [http://www.heikkitoivonen.net/m2crypto/api/M2Crypto.RSA-
 module.html#load_pub_key RSA.load_pub_key] on the file name.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8800#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online