[tor-bugs] #8793 [Tor]: Resolve clang scan-build issues

[Tor Bug Tracker & Wiki]

#8793: Resolve clang scan-build issues
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 The clang analyzer tool "scan-build" reports a bunch of issues on current
 Tor master. On inspection, I believe that there's nothing harmful here.
 (Stuff is false-positive, or harmless, or both.)  But we should
 nevertheless clean it all up if we can.

 For extra points, we should integrate "scan-build" as part of our build
 hygiene process, and get jenkins to flip out when it doesn't pass error-
 free.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8793>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online