[tor-bugs] #8791 [Tor]: munge_extrainfo_into_routerinfo would mishandle a non-extrainfo

[Tor Bug Tracker & Wiki]

#8791: munge_extrainfo_into_routerinfo would mishandle a non-extrainfo
-----------------------------+----------------------------------------------
 Reporter:  nickm            |          Owner:                    
     Type:  defect           |         Status:  new               
 Priority:  trivial          |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:                    
 Keywords:  tor-client easy  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
 If you could somehow make munge_extrainfo_into_routerinfo() get a document
 which wasn't an extrainfo, it would be in trouble, since it assumes that
 the relevant history lines are NUL-terminated.

 For quality-of-implementation, it should check the return value of
 memchr().

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8791>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online