[tor-bugs] #8607 [Stem]: Controller's cache isn't thread safe

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 17 14:49:13 UTC 2013


#8607: Controller's cache isn't thread safe
-----------------------------+----------------------------------------------
 Reporter:  atagar           |          Owner:  atagar      
     Type:  defect           |         Status:  needs_review
 Priority:  normal           |      Milestone:              
Component:  Stem             |        Version:              
 Keywords:  controller easy  |         Parent:              
   Points:                   |   Actualpoints:              
-----------------------------+----------------------------------------------
Changes (by axitkhurana):

  * status:  needs_revision => needs_review


Comment:

 * Updated the doc strings, I hope they are OK now.
 * Added empty line after if/else statements, long docstrings
 * Yeah, caller should do a list wrapper. Fixed.
 * Have to pass func argument to fix the endswith() check. Shouldn't be a
 problem now.
 * Oh, sorry about the pep8 errors, didn't realize it went through.
 * Also, renamed _update_cache to _set_cache.

 Code:
 https://github.com/axitkhurana/stem/commit/7835e08f5122bf3215d36e68a4b98e015d953ac9

 Sorry for the delay, was working on my final year project. Thanks for
 taking the time to review, will try to avoid these in future :)

 Cheers

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8607#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list