[tor-bugs] #8683 [Tor]: moria1 isn't voting for Fast flag when it should

[Tor Bug Tracker & Wiki]

#8683: moria1 isn't voting for Fast flag when it should
---------------------+------------------------------------------------------
 Reporter:  arma     |          Owner:                    
     Type:  defect   |         Status:  new               
 Priority:  blocker  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor      |        Version:                    
 Keywords:           |         Parent:                    
   Points:           |   Actualpoints:                    
---------------------+------------------------------------------------------

Comment(by nickm):

 Losing Exit seems just plain weird.  Looking at dirserv.c, we seem to set
 rs->is_exit from node->is_exit, and we set node->is_exit as:
 {{{
       node->is_exit = (!router_exit_policy_rejects_all(ri) &&
                        exit_policy_is_general_exit(ri->exit_policy));
 }}}
 I don't know what could have gone wrong with that.

 On the Fast issue: we set is_fast as:
 {{{
   rs->is_fast = node->is_fast =
     router_is_active(ri, node, now) &&
     !dirserv_thinks_router_is_unreliable(now, ri, 0, 1);
 }}}
 And dirserv_thinks_router_is_unreliable(ri)'s return value is based on
 comparing (fast_bandwidth, which is set based on
 dirserv_get_credible_bandwidth()) to dirserv_get_bandwidth_for_router(ri).
 Is that correct?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8683#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online