[tor-bugs] #3875 [Firefox Patch Issues]: TBB's Firefox should use optimistic data socks handshake variant

[Tor Bug Tracker & Wiki]

#3875: TBB's Firefox should use optimistic data socks handshake variant
-------------------------------------+--------------------------------------
    Reporter:  arma                  |       Owner:  mikeperry                                                        
        Type:  project               |      Status:  closed                                                           
    Priority:  major                 |   Milestone:  TorBrowserBundle 2.3.x-stable                                    
   Component:  Firefox Patch Issues  |     Version:                                                                   
  Resolution:  fixed                 |    Keywords:  performance roundtrip MikePerry201304 tbb-bounty SponsorF20131101
      Parent:  #3890                 |      Points:                                                                   
Actualpoints:                        |  
-------------------------------------+--------------------------------------
Changes (by mikeperry):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 I merged this for the next TBB alpha and stable release (I merged it to
 both because we don't have the ability to have separate patches for TBB-
 alpha and TBB-stable at the moment).

 I've been running this for a while against an 0.2.4.x client and I've been
 getting successful optimistic data messages in my logs, and I haven't seen
 any strange errors.

 I am a little worried because other things than just SOCKS use
 nsISocketTransport (including Torbutton's control port activity). I
 haven't seen any obvious issues so far, though.

 I'll keep an eye on it in debug builds for a while longer, and look into
 the overall behavior a bit closer for #8184.

 But it seems good so far! Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3875#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online