[tor-bugs] #8596 [Tor]: Inconsistent addrmap events when resolving hostname (regression)

[Tor Bug Tracker & Wiki]

#8596: Inconsistent addrmap events when resolving hostname (regression)
-----------------------+----------------------------------------------------
    Reporter:  Desoxy  |       Owner:                           
        Type:  defect  |      Status:  reopened                 
    Priority:  normal  |   Milestone:  Tor: 0.2.4.x-final       
   Component:  Tor     |     Version:  Tor: 0.2.4.11-alpha      
  Resolution:          |    Keywords:  tor-client controller dns
      Parent:          |      Points:                           
Actualpoints:          |  
-----------------------+----------------------------------------------------
Changes (by atagar):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Sorry to reopen but I need a little clarification about the new CACHED
 arg. In an example above the YES/NO was quoted - is that how it ended up
 being implemented?

 {{{
 650 ADDRMAP example.com 192.0.43.10 "2013-04-03 22:31:22"
 EXPIRES="2013-04-03 20:31:22" CACHED="YES"
 }}}

 If so then the spec change should be changed from...

 {{{
 Cached = "YES" / "NO"
 }}}

 ... which, contrary to the quotes, mean bare word arguments. I suspect the
 right specification would be something like...

 {{{
 Cached = DQUOTE "YES" DQUOTE / DQUOTE "NO" DQUOTE
 }}}

 Also, this is more of a stem-specific question but what would be the best
 behavior for when this flag isn't present? Should the event's cached
 attribute be defaulted to True or False? Or should the attribute take on
 the values of True / False / None (for undefined)?

 Thanks! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8596#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online