[tor-bugs] #8607 [Stem]: Controller's cache isn't thread safe

[Tor Bug Tracker & Wiki]

#8607: Controller's cache isn't thread safe
-----------------------------+----------------------------------------------
 Reporter:  atagar           |          Owner:  atagar        
     Type:  defect           |         Status:  needs_revision
 Priority:  normal           |      Milestone:                
Component:  Stem             |        Version:                
 Keywords:  controller easy  |         Parent:                
   Points:                   |   Actualpoints:                
-----------------------------+----------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_revision


Comment:

 Hi Akshit. I'm presently at work so I was only able to give this a quick
 look, but we should definitely add a test for the CONF_CHANGED fix. The
 change you wrote actually looks to be a no-op due to whitespace (the
 add_event_listener() call is indented too far, so it's actually *in* the
 _conf_changed_listener block).

 No tests necessary for the concurrency fix (that would be hard to repro).
 Let me know when the CONF_CHANGED addition has a test and I'll give it a
 more through review.

 Thanks for the fixes! -Damian

 PS. Minor nitpick, but please start your commit messages with a capital
 letter. Also, it would be nice if they mentioned the ticket that they're
 resolving.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8607#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online