[tor-bugs] #8628 [Firefox Patch Issues]: Inconsistent image cache key usage

[Tor Bug Tracker & Wiki]

#8628: Inconsistent image cache key usage
----------------------------------------------+-----------------------------
 Reporter:  mikeperry                         |          Owner:  mikeperry
     Type:  defect                            |         Status:  new      
 Priority:  major                             |      Milestone:           
Component:  Firefox Patch Issues              |        Version:           
 Keywords:  MikePerry201304, tbb-linkability  |         Parent:           
   Points:                                    |   Actualpoints:           
----------------------------------------------+-----------------------------

Comment(by gk):

 Okay, the good news is that I did not get a single crash anymore. What
 makes me quite nervous, though, are loads of assertions of the type

 ###!!! ASSERTION: More UnblockOnload() calls than BlockOnload() calls;
 dropping call: 'Not Reached', file /home/firefox64/TBB/debug-build
 /mozilla-esr17/content/base/src/nsDocument.cpp, line 7174
 ###!!! ASSERTION: Shouldn't have a count of zero here, since we stabilized
 in PostUnblockOnloadEvent: 'mOnloadBlockCount != 0', file
 /home/firefox64/TBB/debug-build/mozilla-
 esr17/content/base/src/nsDocument.cpp, line 7224
 ###!!! ASSERTION: Double UnblockOnload!?: 'mCurrentRequestFlags &
 REQUEST_BLOCKS_ONLOAD', file /home/firefox64/TBB/debug-build/mozilla-
 esr17/content/base/src/nsImageLoadingContent.cpp, line 598

 That happens especially on pages with lots of images. While I have not
 tested the old patch (or a default Fx build) again I am quite confident
 that these assertions would have caught my attention if they would have
 been there. But maybe I am wrong here, dunno...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8628#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online