[tor-bugs] #8628 [Firefox Patch Issues]: Inconsistent image cache key usage

[Tor Bug Tracker & Wiki]

#8628: Inconsistent image cache key usage
----------------------------------------------+-----------------------------
 Reporter:  mikeperry                         |          Owner:  mikeperry
     Type:  defect                            |         Status:  new      
 Priority:  major                             |      Milestone:           
Component:  Firefox Patch Issues              |        Version:           
 Keywords:  MikePerry201304, tbb-linkability  |         Parent:           
   Points:                                    |   Actualpoints:           
----------------------------------------------+-----------------------------
 While puzzling over our three image-cache related crash bugs (#8601,
 #8559, and #8618), I noticed that the cache key usage was inconsistent in
 one of the codepaths that caused a crash: We had reversed the first party
 URI vs the originating URI arguments on one of the calls to GetCacheKey().

 I am filing a new ticket because I'm not sure this is the real source of
 all of the crashes, but it is certainly a bug on its own (possibly
 resulting in cache isolation flaws and potential third party linkability).

 If by some miracle this patch actually does fix all the crashes, we'll
 just dup them to this bug.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8628>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online