[tor-bugs] #8625 [Tor]: Do not call networkstatus_reset_download_failures() hourly

[Tor Bug Tracker & Wiki]

#8625: Do not call networkstatus_reset_download_failures() hourly
-------------------------------------+--------------------------------------
 Reporter:  nickm                    |          Owner:                    
     Type:  defect                   |         Status:  new               
 Priority:  normal                   |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                      |        Version:                    
 Keywords:  tor-client 024-backport  |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------
 Once an hour, we call router_reset_descriptor_download_failures, which
 calls networkstatus_reset_download_failures().  This probably isn't right!
 Our download logic has a way to say "Try this once an hour": that's by
 having a download schedule with a one-hour interval.  What this does is
 make us retry several times an hour, as if we had never failed before.

 Found while investigating #4580 .

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8625>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online