[tor-bugs] #6708 [pyonionoo]: Pyonionoo returns code 500 for a few parameters

[Tor Bug Tracker & Wiki]

#6708: Pyonionoo returns code 500 for a few parameters
-----------------------+----------------------------------------------------
 Reporter:  karsten    |          Owner:  gsathya     
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  pyonionoo  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by gsathya):

 Replying to [comment:16 karsten]:
 > Replying to [comment:14 gsathya]:
 > > Aha gotcha! I'm wondering why not have a default value of '??' or
 "null" if there are no flags in the summary document? It makes sense to
 not use whitespace as a value since we're parsing it based on position of
 the text.
 >
 > Oh, we don't use whitespace as the value here.  The value is an empty
 string that has space characters as its left and right delimiters.  Think
 that if we used commas as separators, there would be two subsequent
 commas.  "??" would mean we don't know which flags there are, but we do
 know that there are none.  "null" is a string, too, so we'd have to
 special-case that in order not to confuse it with the "null" flag.  I
 think that an empty string is correct here.  We just need to prevent
 Python from merging delimiters and make it account for the case of empty
 strings.

 Oh, okay. Makes sense.

 > > Merged the other two commits. Thanks!
 >
 > Thanks!
 >
 > That means there's one commit left now in my branch.  Does it need
 better comments in the code and/or commit message?  If so, can you suggest
 a phrasing?

 This is fine. I've merged and pushed it. Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6708#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online