[tor-bugs] #6131 [Torflow]: bwauths learn to recognize Capped=1 in consensus line and treat it differently
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sat Sep 22 20:51:19 UTC 2012
#6131: bwauths learn to recognize Capped=1 in consensus line and treat it
differently
---------------------+------------------------------------------------------
Reporter: arma | Owner: aagbsn
Type: task | Status: needs_revision
Priority: normal | Milestone:
Component: Torflow | Version:
Keywords: | Parent: #2286
Points: | Actualpoints:
---------------------+------------------------------------------------------
Comment(by aagbsn):
Replying to [comment:6 mikeperry]:
> Two points from the review:
>
> 1. You transform the ratio_r[i] object into an integer 1 for the capped
case. This will cause explosions.
Wait? Do you mean ratio_rank? Isn't that supposed to be an integer? If
not, what about TorCtl.py:1647
{{{
for i in xrange(len(ratio_r)): ratio_r[i].ratio_rank = i
}}}
>> Better than trying to hack the ratio_rank directly, you should alter
the ratio_r sorting to use a Router.get_unmeasured_bw() method to return
the NetworkStatus bw value instead of desc_bw if unmeasured is true...
Then the ratio will work out to 1 that way.
>
> 2. Please change "Capped" to "Unmeasured". See
https://trac.torproject.org/projects/tor/ticket/2286#comment:45 for why.
Ok.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6131#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list