[tor-bugs] #4645 [Tor Client]: Deprecate and remove is_internal_IP

[Tor Bug Tracker & Wiki]

#4645: Deprecate and remove is_internal_IP
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:1 nickm]:
 > Adding "easy" since this is easy to do, but could you explain why?

  * `is_internal_IP` operates on IP addresses stored in a data type which
 can only handle IPv4 addresses.
  * `is_internal_IP` operates on IP addresses represented as `uint32_t`
 values; this representation risks a byte-order mismatch.  (A byte-order
 mismatch bug involving IPv4 addresses turned up recently in Tor.)
 Everything which calls `is_internal_IP` could stand to be audited for this
 type of bug anyway.

-- 
Ticket URL: <https://trac.torproject.org:443/projects/tor/ticket/4645#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online