[tor-bugs] #6131 [Torflow]: bwauths learn to recognize Capped=1 in consensus line and treat it differently

[Tor Bug Tracker & Wiki]

#6131: bwauths learn to recognize Capped=1 in consensus line and treat it
differently
---------------------+------------------------------------------------------
 Reporter:  arma     |          Owner:  aagbsn        
     Type:  task     |         Status:  needs_revision
 Priority:  normal   |      Milestone:                
Component:  Torflow  |        Version:                
 Keywords:           |         Parent:  #2286         
   Points:           |   Actualpoints:                
---------------------+------------------------------------------------------
Changes (by mikeperry):

  * status:  needs_review => needs_revision


Comment:

 Two points from the review:

 1. You transform the ratio_r[i] object into an integer 1 for the capped
 case. This will cause explosions. Better than trying to hack the
 ratio_rank directly, you should alter the ratio_r sorting to use a
 Router.get_unmeasured_bw() method to return the NetworkStatus bw value
 instead of desc_bw if unmeasured is true... Then the ratio will work out
 to 1 that way.

 2. Please change "Capped" to "Unmeasured". See
 https://trac.torproject.org/projects/tor/ticket/2286#comment:45 for why.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6131#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online