[tor-bugs] #6465 [Tor Relay]: Build abstraction layer around TLS

[Tor Bug Tracker & Wiki]

#6465: Build abstraction layer around TLS
-----------------------+----------------------------------------------------
 Reporter:  andrea     |          Owner:  andrea            
     Type:  project    |         Status:  needs_review      
 Priority:  major      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:  Tor: unspecified  
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Replying to [comment:28 andrea]:
 > Responses to part 2 (points in potential need of further discussion):

 Hi! On this and on part one above, please assume anything that I don't
 respond to, I agree with.  (If it seems especially tricky, it might
 deserve a comment.)

 > > In channel_process_cells, I feel like maybe we're going to hit trouble
 if
 > > there isn't a way to break out in the middle of processing all those
 cells?
 > > I guess that might be happening in the middle of the processing
 functions,
 > > where they note if there's an error and don't process anything if an
 error
 > > has occurred.
 >
 > The latter; the cell handlers that calls are just the old code path in
 > command.c, less the handshaking stuff that went to channeltls.c.

 ok; could use a comment then.

 > > In channel_send_destroy, I am confused about why we're calling
 > > channel_write_cell instead of channel_queue_cell. In fact, it's likely
 > > that I'm going to have this confusion about every channel_write_cell/
 > > channel_queue_cell instance. Hmm. I wonder if there's any way we can
 make
 > > those more distinct/obvious/safe?
 >
 > Hmm, how would you feel about s/channel_write_cell/channel_send_cell/g
 and
 > s/channel_queue_cell/channel_recv_cell/g ?

 Oh hm. I think of channel_recv_cell as meaning that a cell is coming from
 the network.  Is *that* what it means?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6465#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online