[tor-bugs] #4283 [Tor Client]: crypto_pk_cmp_keys does not document its error behaviour

Mon Sep 17 14:53:43 UTC 2012

#4283: crypto_pk_cmp_keys does not document its error behaviour
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by rransom):

  * status:  needs_revision => needs_review

Comment:

 Replying to [comment:14 nickm]:
 > I added a quick unit test in branch "bug4283" in my public repo, just to
 make sure of the new NULL behavior, and whoops! It looks like your
 implementation crashes on crypto_pk_cmp_keys(NULL, NULL).

 Oops.  Fix pushed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4283#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online