[tor-bugs] #6861 [Tor Client]: Undefined behavior in rend_parse_service_authorization()

[Tor Bug Tracker & Wiki]

#6861: Undefined behavior in rend_parse_service_authorization()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm_mobile):

 Hm. I could have sworn that rightshifting signed integers in C was
 implementation-defined, not undefined.  I also thought we maybe had a
 check for it, in di_ops.c.  I'll check both when online on a real computer
 again.

 Still, it's still wrong in this case.  Implementations are allowed to
 signextend, and that's wrong here.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6861#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online