[tor-bugs] #6858 [Ooni]: HTTP Protocol Helper
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sun Sep 16 01:42:31 UTC 2012
#6858: HTTP Protocol Helper
-------------------------------------------+--------------------------------
Reporter: isis | Owner: hellais
Type: task | Status: new
Priority: normal | Milestone:
Component: Ooni | Version:
Keywords: helpers, protocol, ooni-probe | Parent: #6857
Points: | Actualpoints:
-------------------------------------------+--------------------------------
Comment(by isis):
The HTTP helper, /ooni/protocols/http.py, tries to do "from
twisted.web.client import RedirectAgent" without checking Twisted's
version or the client OS version. In Debian stable, the latest version of
Twisted in 10.1.0, in which the RedirectAgent class does not exist. Also,
because the HTTP helper tries to do imports without knowing if they will
be used or not, this prevents ooniprobe.py from running entirely.
If we are planning for Twisted-12.x, we should include some sort of
install script which gets and builds it for us.
Either way, we should always do smart checking on imports to avoid
breaking without explaining to the user what is going on, and we should
avoid importing uneccessary modules.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6858#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list