[tor-bugs] #4283 [Tor Client]: crypto_pk_cmp_keys does not document its error behaviour

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Sep 13 21:14:46 UTC 2012


#4283: crypto_pk_cmp_keys does not document its error behaviour
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Actually, I don't see why we shouldn't do that right now. (That is, define
 NULL==NULL, and NULL < everything else.)

 Also, defining a crypto_pk_eq() function to wrap
 (0==crypto_pk_cmp_keys(a,b)) would probably help readability.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4283#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list