[tor-bugs] #6696 [Compass]: add Byte/s to Advertised Bandwidth column

[Tor Bug Tracker & Wiki]

#6696: add Byte/s to Advertised Bandwidth column
-------------------------+--------------------------------------------------
 Reporter:  cypherpunks  |          Owner:  gsathya     
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Compass      |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by gsathya):

 * cc: atagar (added)
  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 karsten]:
 > Hmmm, that branch doesn't merge cleanly anymore.  Would you mind
 rebasing it onto current master?

 Done. Please review my
 [https://github.com/gsathya/compass/compare/master...bug_6696 bug_6696]
 branch.

 There's a bug in this though - the formatting is off when you run {{{
 ./compass -A }}}

 {{{
 compass git:(bug_6696): ./compass.py
        CW  adv_bw(MB/s)   P_guard   P_Middle   P_exit Nickname
 Fingerprint                              Exit Guard CC Autonomous System
   2.2898%  30.86  1.02%   1.7928%   1.7928%   3.2838% chaoscomputerclub20
 CFA48FC3E843DFF01AA026EC77010AB57E8C2FF0 Exit Guard de AS39138 rrbone UG
 (haftungsbeschraenkt)
   1.5617%  23.83  0.79%   1.2228%   1.2228%   2.2397% TorLand1
 D223399907113A1F216AAA64997BC1D4CFA8E1AC Exit Guard gb AS29302 Hosting
 Services Inc
   1.5148%  22.73  0.75%   1.1860%   1.1860%   2.1724% chaoscomputerclub21
 B8F81CF0C665EA8BE947F102CBFF97615F1FF300 Exit Guard de AS39138 rrbone UG
 (haftungsbeschraenkt)
   1.3739%  30.15  1.00%   1.0757%   1.0757%   1.9703% chaoscomputerclub19
 A59E1E7C7EAEE083D756EE1FF6EC31CA3D8651D7 Exit Guard de AS39138 rrbone UG
 (haftungsbeschraenkt)
   1.3269%  24.96  0.83%   0.0000%   0.0000%   3.9810% lumumba
 24B1F63F7DF9F85D711864811CC401BE5EB5FB9A Exit -     nl AS43350 NFOrce
 Entertainment BV
   1.2799%  29.72  0.98%   1.0021%   1.0021%   1.8356% chaoscomputerclub18
 AD6C2377E01611F56C33F84BB4AE663A1DA5B3B3 Exit Guard de AS39138 rrbone UG
 (haftungsbeschraenkt)
   1.2682%  20.58  0.68%   0.9929%   0.9929%   1.8187% rainbowwarrior
 DB8C6D8E0D51A42BDDA81A9B8A735B41B2CF95D1 Exit Guard nl AS43350 NFOrce
 Entertainment BV
   1.2447%  14.64  0.48%   2.3744%   1.3595%   0.0000% UWDesktop
 2501EFFB7AEF0F846326646D9869E46E664BB8E7 -    Guard us AS73 University of
 Washington
   1.1554%  49.57  1.64%   0.9047%   0.9047%   1.6571% bolobolo3
 4F8D80A0F768A2A29856A8F26B05D35DEAA39850 Exit Guard us AS8100 IPTelligent
 LLC
   1.1320%  15.04  0.50%   0.0000%   0.0000%   3.3962% Unnamed
 AE5A97FA3591F133D8D039232CF0005088190C91 Exit -     se AS47155 ViaEuropa
 Sweden
  85.8528%        91.32%  89.4485%  90.4637%  77.6451% (3030 other relays)
 }}}

 {{{
 compass git:(bug_6696): ./compass.py -A
        CW  adv_bw(MB/s)   P_guard   P_Middle   P_exit Nickname
 Fingerprint                              Exit Guard CC Autonomous System
   9.7926%  231.78  7.67%   8.0915%  11.5307%   9.7555% *
 (97 relays)                              (41) (52)  fr AS16276 OVH Systems
   6.4583%  113.47  3.76%   5.0567%   5.0565%   9.2621% *
 (4 relays)                               (4)  (4)   de AS39138 rrbone UG
 (haftungsbeschraenkt)
   5.1660%  167.06  5.53%   6.7011%   7.3081%   1.4884% *
 (146 relays)                             (26) (90)  de AS24940 Hetzner
 Online AG RZ
   4.7872%  122.67  4.06%   1.7602%   1.6401%  10.9624% *
 (8 relays)                               (5)  (4)   nl AS43350 NFOrce
 Entertainment BV
   3.5932%  77.01  2.55%   2.8134%   2.8133%   5.1531% *
 (7 relays)                               (7)  (7)   us AS22219 Applied
 Operations, LLC
   3.5403%  119.59  3.96%   2.7573%   2.8082%   5.0558% *
 (11 relays)                              (8)  (7)   us AS29761 OC3
 Networks & Web Solutions, LLC
   2.6855%  94.97  3.14%   5.1229%   2.9331%   0.0000% *
 (11 relays)                              (0)  (11)  us AS23028 Team Cymru
 Inc.
   2.5961%  91.78  3.04%   4.8927%   2.8191%   0.0761% *
 (8 relays)                               (1)  (8)   us AS29854 WestHost,
 Inc.
   2.3109%  72.85  2.41%   1.8094%   1.8093%   3.3141% *
 (3 relays)                               (3)  (3)   us AS8100 IPTelligent
 LLC
   2.0017%  37.16  1.23%   0.0000%   0.0025%   6.0033% *
 (6 relays)                               (3)  (0)   se AS47155 ViaEuropa
 Sweden
  57.0682%        62.64%  60.9950%  61.2791%  48.9292% (833 other ASes)
 }}}

 The bug is in line
 [https://github.com/gsathya/compass/blob/bug_6696/compass.py#L277 #L277]
 and  [https://github.com/gsathya/compass/blob/bug_6696/compass.py#L279
 #L279].  Damian, help?

 Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6696#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online