[tor-bugs] #6341 [Tor Relay]: connection_or_flush_from_first_active_circuit() does wrong thing when ewma_enabled

[Tor Bug Tracker & Wiki]

#6341: connection_or_flush_from_first_active_circuit() does wrong thing when
ewma_enabled
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 Replying to [comment:45 robgjansen]:
 > > Set "FetchDirInfoEarly 1" in the torrc for each Tor that should fetch
 that way.
 >
 > I thought this meant the clients would try to fetch whatever info they
 needed earlier. Are you telling me I should take these lines back out for
 regular clients?

 If they work, by all means keep them for now. Eventually I'd like to get
 to the point where we don't need them, since they make our simulation a
 bit less realistic and might introduce other issues at scale: not only do
 they make the directory fetching happen earlier, but they also make
 everybody only ask your directory authority when fetching dir stuff.

 As another fun example of bizarre behavior, if you set FetchDirInfoEarly
 on a client, that makes directory_fetches_from_authorities() return true,
 which makes directory_command_should_use_begindir() return false, which
 makes use_begindir false in directory_initiate_command_rend(), which
 causes the dir fetches to be done via vanilla http rather than tunneled
 inside TLS. And with only one dir auth, due to #6761, all but one
 directory fetch for descriptors or microdescriptors will be silently
 discarded. Not the end of the world (everything still mostly works), but
 certainly not on the normal path. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6341#comment:48>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online