[tor-bugs] #7157 [Tor]: "Low circuit success rate %u/%u for guard %s=%s."

[Tor Bug Tracker & Wiki]

#7157: "Low circuit success rate %u/%u for guard %s=%s."
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  new => needs_revision


Comment:

 quick review:

   * pathbias_count_timeout() should be declared in circuitbuild.h, not
 or.h.  We shouldn't be declaring functions in or.h any more.
   * "crited" isn't a word; what do you mean it to mean?  If "crit" is the
 verb, I think "critted" is the past participle, but...?
   * You can't take something out of or_options_t without adding an
 OBSOLETE() entry for it, or an alias for it in the aliases table.
 Otherwise every torrc that used it would suddenly break.
   * All functions and fields and options need documentation.  I shouldn't
 have to go read the proposal to find out what a "mult factor" is; the
 comments and the manpage should explain it.
   * I have a hard time understanding why the code does "%" in
 "((mult_factor * foo) % scale_factor) == 0". I guess that you're trying to
 avoid integer truncation, but won't this prevent scaling entirely?
 Suppose scale_factor is 100. It seems to me that unless first_hops and
 circuit_successes are both divisible by 100 at the same time, they'll
 never get scaled.  Can't we just reserve scaling for when the values are
 "big enough" that integer truncation won't matter?
   * LD_PROTOCOL might not be appropriate here; that's for protocol
 violations, not for malfunctioning nodes.
   * The "your guard %s=%s" code should probably get refactored to use the
 same format as node_describe , and probably to be an independent function.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7157#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online