[tor-bugs] #7016 [Flashproxy]: Make flashproxy-client a managed proxy.

[Tor Bug Tracker & Wiki]

#7016: Make flashproxy-client a managed proxy.
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  dcf         
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Flashproxy   |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by asn):

 Replying to [comment:2 dcf]:
 > Here is an implementation for review:
 >
 >
 https://gitweb.torproject.org/user/dcf/flashproxy.git/shortlog/refs/heads/managed
 >

 The code looks sane.

 Although, I'm wondering: why did you implement proposal 180 on your own
 and didn't use pyptlib? The main reason we wrote pyptlib is so that you
 don't have to implement proposal 180. Did you not like the API, did you
 find the documentation unreadable, or did you just want to implement
 something on your own?

 In any case, the code looks good. Did you test it with Tor? Does it work?
 I will monitor #5575 for the server-side case.

 > Some thoughts:
 > * It uses a `--managed` option. Maybe, since this is planned to be the
 most standard use, `--managed` should be the default and `--external` be
 an option?

 Yeah, I've been thinking about this myself too.

 I still haven't decided if it would be helpful (because you don't have to
 append --managed in the end of the ClientTransportPlugin line), or
 confusing (who try to execute 'flashproxy' and get "ENV-ERROR Cannot find
 TOR_PT_STATE_LOC" in stdout) to people.

 > * What's the best way to ship a default `torrc`? I am using the path
 `./flashproxy-client` in the
 [https://gitweb.torproject.org/user/dcf/flashproxy.git/blob/refs/heads/managed:/torrc
 torrc], which works if you run from the source directory, but not if you
 install to `/usr/local/bin`.

 Hm, what do you mean?

 If you are asking how you would spawn flashpproxy in a Tor Browser Bundle;
 you would probably have a `ClientTransportPlugin` line like this:
 `ClientTransportPlugin websocket exec ./App/flashproxy-client --managed`
 and `flashproxy-client` would be placed in the top-level `/App/` directory
 of the Tor Browser Bundle.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7016#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online