[tor-bugs] #7191 [Tor]: smartlist_bsearch_idx() is broken for short lists

[Tor Bug Tracker & Wiki]

#7191: smartlist_bsearch_idx() is broken for short lists
-----------------------------------------+----------------------------------
 Reporter:  andrea                       |          Owner:  andrea            
     Type:  defect                       |         Status:  needs_review      
 Priority:  major                        |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor                          |        Version:  Tor: 0.2.4.3-alpha
 Keywords:  tor-relay denial-of-service  |         Parent:                    
   Points:                               |   Actualpoints:                    
-----------------------------------------+----------------------------------

Comment(by andrea):

 Replying to [comment:19 nickm]:
 > There's talk on #tor-dev of doing a minimal version of this for 0.2.2
 and/or 0.2.3, and doing the full fix in less stable versions.  For my idea
 of what a minimal one might look like, see branch "bug7191_minimal" in my
 public repository, which is TOTALLY UNTESTED AND UNREVIEWED.

 That patch looks correct to me.  Maybe it'd be worth you cherrypicking my
 test suite improvements to check it?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7191#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online