[tor-bugs] #7129 [Tor]: circuit_end_reason_to_control_string(): Bug: Unrecognized reason code 13

[Tor Bug Tracker & Wiki]

#7129: circuit_end_reason_to_control_string(): Bug: Unrecognized reason code 13
----------------------------+-----------------------------------------------
    Reporter:  cypherpunks  |        Type:  defect
      Status:  new          |    Priority:  normal
   Milestone:               |   Component:  Tor   
     Version:               |    Keywords:        
      Parent:               |      Points:        
Actualpoints:               |  
----------------------------+-----------------------------------------------

Comment(by andrea):

 Looks like I just renamed END_CIRC_REASON_OR_CONN; relevant section of
 diff on src/or/or.h from 016c21d871a8fedcd07b7aaca43e47315013c1d4 right
 before the channel_t merge to 94a030990986e6c731141da3969aeae3ec0f5ea8
 (current head) follows:

  /* Reasons why we (or a remote OR) might close a circuit. See tor-
 spec.txt for
   * documentation of these. */
 -#define _END_CIRC_REASON_MIN            0
 +#define END_CIRC_REASON_MIN_            0
  #define END_CIRC_REASON_NONE            0
  #define END_CIRC_REASON_TORPROTOCOL     1
  #define END_CIRC_REASON_INTERNAL        2
 @@ -674,12 +674,12 @@ typedef enum {
  #define END_CIRC_REASON_RESOURCELIMIT   5
  #define END_CIRC_REASON_CONNECTFAILED   6
  #define END_CIRC_REASON_OR_IDENTITY     7
 -#define END_CIRC_REASON_OR_CONN_CLOSED  8
 +#define END_CIRC_REASON_CHANNEL_CLOSED  8
  #define END_CIRC_REASON_FINISHED        9
  #define END_CIRC_REASON_TIMEOUT         10
  #define END_CIRC_REASON_DESTROYED       11
  #define END_CIRC_REASON_NOSUCHSERVICE   12
 -#define _END_CIRC_REASON_MAX            12
 +#define END_CIRC_REASON_MAX_            12

 In light of this it seems quite unlikely that this was introduced by
 channels.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7129#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online