[tor-bugs] #7128 [TorBrowserButton]: Tor Browser crashes when clicking on link

[Tor Bug Tracker & Wiki]

#7128: Tor Browser crashes when clicking on link
---------------------------------+------------------------------------------
    Reporter:  proper            |       Owner:  mikeperry      
        Type:  defect            |      Status:  closed         
    Priority:  critical          |   Milestone:                 
   Component:  TorBrowserButton  |     Version:                 
  Resolution:  fixed             |    Keywords:  MikePerry201210
      Parent:                    |      Points:                 
Actualpoints:  2                 |  
---------------------------------+------------------------------------------
Changes (by mikeperry):

  * status:  new => closed
  * keywords:  => MikePerry201210
  * resolution:  => fixed
  * actualpoints:  => 2


Comment:

 Ok, I think I got to the bottom of this. Turns out NoScript's ClearClick
 was creating and HTML5 canvas with no context. This was causing us to
 deref a null window pointer in the new ThirdPartyUtil::GetFirstPartyURI()
 call when we checked permissions for access to the canvas image data as
 part of #6253.

 I pushed an updated patch for the GetFirstPartyURI() call to maint-2.2. I
 also filed #7130 to solve the deeper issue of why NoScript has no context
 for the API call and/or to whitelist chrome callers for the canvas patch.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7128#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online