[tor-bugs] #7116 [- Select a component]: differing return type in definition and declaration of dirserv_add_extrainfo

Mon Oct 15 12:54:05 UTC 2012

#7116: differing return type in definition and declaration of
dirserv_add_extrainfo
-----------------------------------+----------------------------------------
    Reporter:  schachmat           |        Type:  defect              
      Status:  new                 |    Priority:  normal              
   Milestone:                      |   Component:  - Select a component
     Version:  Tor: 0.2.4.3-alpha  |    Keywords:                      
      Parent:                      |      Points:                      
Actualpoints:                      |  
-----------------------------------+----------------------------------------
 We're trying to compile Tor with cparser and got an error.

 src/or/dirserv.c:803:1: error: declaration 'was_router_added_t
 dirserv_add_extrainfo(extrainfo_t*, const char**)' is incompatible with
 'int dirserv_add_extrainfo(extrainfo_t*, const char**)' (declared at
 line 96:12)

 The attached patch fixes this error due to inconsistently declared a
 return type (once declared as 'enum', once as 'int').

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7116>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online