[tor-bugs] #7103 [Stem]: Clean orphaned *pyc files

[Tor Bug Tracker & Wiki]

#7103: Clean orphaned *pyc files
----------------------------+-----------------------------------------------
    Reporter:  atagar       |       Owner:  neena 
        Type:  enhancement  |      Status:  closed
    Priority:  minor        |   Milestone:        
   Component:  Stem         |     Version:        
  Resolution:  implemented  |    Keywords:        
      Parent:               |      Points:        
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 > What do you think about just printing a message listing the ghost pyc
 files instead of deleting them?

 Hmmm, I can't think of any use case where the tester wouldn't want the
 orphaned pyc to be deleted. Can you?

 One thing that I dislike a little bit about this change is that we now
 have two static analysis tasks: pyc cleanup and whitespace checking.
 Ideally they'd both be in the same section, but...

 - the pyc cleanup needs to come before the tests since otherwise we'll use
 those orphaned pycs in tests

 - the whitespace checking needs to come after the tests since otherwise
 the other testing output will drown it out

 Oh well, guess having both pre-testing and post-testing steps isn't the
 end of the world.

 A more concerning gotcha is that even with this change we might still test
 against orphaned pyc files since the test_runner.py has numerous imports
 *before* we clean them up. If any of those imports leads to an orphaned
 pyc then it'll be in memory anyway.

 I'm gonna push this for now. Improvements welcome!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7103#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online