[tor-bugs] #7011 [Tor]: Stored IPv6 TransportProxy bindaddr lacks brackets

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Oct 8 03:44:41 UTC 2012


#7011: Stored IPv6 TransportProxy bindaddr lacks brackets
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  asn               
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-bridge  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  needs_review => needs_revision


Comment:

 Maybe review of this patchset would be easier if [PATCH 4/5] did not
 invalidate the previous patches? I think it would make more sense if the
 patchset introduced `fmt_addrport()` right from the beginning and then
 simply used it.

 Also, this patchset makes `make check-spaces` fail because of wide lines.

 David, do you have the time and will to address the above comments or
 shall I?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7011#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list