[tor-bugs] #6411 [Tor]: Adding hidden services through control socket

[Tor Bug Tracker & Wiki]

#6411: Adding hidden services through control socket
----------------------------------------------------------+-----------------
 Reporter:  kevinevans                                    |          Owner:                    
     Type:  enhancement                                   |         Status:  needs_revision    
 Priority:  normal                                        |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                                           |        Version:  Tor: 0.2.3.19-rc  
 Keywords:  hidden-service control maybe-proposal tor-hs  |         Parent:                    
   Points:                                                |   Actualpoints:                    
----------------------------------------------------------+-----------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 This could use a design proposal -- as it stands, I'm not really sure what
 the command is supposed to do, since there's no documentation for it.   At
 the very least, it needs a patch for control-spec to explain what it does.

 Some other issues a proposal should address:

 Why does the controller need to generate their own private key?

 Why does the controller need to figure out the hostname?   Why is it even
 there -- the code never looks at it except to check its length.



 The patch itself has some issues that would need to be fixed, including:

   * It parses a controller line in rendservice.c.  By convention, all the
 controller parsing is done in control.c; rendservice.c should get at most
 a new "add a service" function.
   * There's a heap overflow if the private key argument is too long.
   * It checks to make sure that there are enough arguments after it's
 already looked at one of them.
   * It fails badly if there are an odd number of ports, or if
 parse_port_config fails.
   * The variable "p" doesn't have any purpose.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online