[tor-bugs] #7011 [Tor]: Stored IPv6 TransportProxy bindaddr lacks brackets

[Tor Bug Tracker & Wiki]

#7011: Stored IPv6 TransportProxy bindaddr lacks brackets
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  asn               
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-bridge  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by dcf):

  * status:  new => needs_review


Comment:

 Here is a patch set doing these things. It is meant to be applied on top
 of
 https://gitorious.org/mytor/mytor/commit/acfebfdc3907cb1838b7b7dcf6913f22ebce4c72
 from https://trac.torproject.org/projects/tor/ticket/7014#comment:3.

 [PATCH 1/5] decorates all addresses in log messages. This should be
 uncontroversial as it doesn't affect any network or on-disk format.
 [PATCH 2/5] decorates addresses in HTTP CONNECT proxy requests.
 [PATCH 3/5] decorates the `TransportProxy` statefile entry, the subject of
 this ticket.
 [PATCH 4/5] adds a new `fmt_addrport` function to factor out the common
 "%s:%d" formatting.
 [PATCH 5/5] uses `fmt_addrport` where appropriate.

 There was only one `fmt_addr` I wasn't sure how to deal with, in
 `pt_get_extra_info_descriptor_string` in `transports.c`:
 {{{
       const char *addr_str = fmt_addr(&t->addr);
       ...
       smartlist_add_asprintf(string_chunks,
                              "transport %s %s:%u",
                              t->name, addr_str, t->port);
 }}}
 I don't know for sure whether the brackets are wanted here or not. I am
 guessing they are.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7011#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online