[tor-bugs] #7011 [Tor]: Stored IPv6 TransportProxy bindaddr lacks brackets

[Tor Bug Tracker & Wiki]

#7011: Stored IPv6 TransportProxy bindaddr lacks brackets
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  asn
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor         |        Version:     
 Keywords:  tor-bridge  |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
Changes (by asn):

  * priority:  minor => normal


Comment:

 I started looking at `src/or/transports.c` to find occurences of
 `fmt_addr()` that should be changed to `fmt_and_decorate_addr()` and I
 noticed that all the `fmt_addr()`s should be changed
 (https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/transports.c#l277
 https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/transports.c#l284
 https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/transports.c#l333
 https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/transports.c#l645
 etc.).

 I started thinking that maybe it would make sense to change the behavior
 of `fmt_addr()` so that it does decorate IPv6 addresses by default, but
 then `jeroen` in IRC reminded me that bracket decoration is only necessary
 when ':' is used a separator, and maybe we shouldn't decorate all the
 addresses.

 I think I will proceed with looking at all the pluggable-transport-related
 code and turning `fmt_addr()` to `fmt_and_decorate_addr()` when needed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7011#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online