[tor-bugs] #6997 [Tor Client]: tor --version should imply --quiet

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Oct 1 15:05:36 UTC 2012


#6997: tor --version should imply --quiet
----------------------------+-----------------------------------------------
    Reporter:  arma         |       Owner:                    
        Type:  defect       |      Status:  closed            
    Priority:  normal       |   Milestone:  Tor: 0.2.4.x-final
   Component:  Tor Client   |     Version:                    
  Resolution:  implemented  |    Keywords:  easy              
      Parent:               |      Points:                    
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by nickm):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 Tweaked and applied!

 Here are  some suggestions for your next patch:
  * The "git format-patch" tool generates output that includes an author
 line and a commit message, which makes it faster for me to merge the
 patch.
  * Please try to match the indentation of the surrounding code. Tor's
 doc/HACKING file has the appropriate magic to make emacs and vim do this
 for you.
  * We try not to refer to ticket numbers in the Tor source--we want the
 source and the documentation and the specifications to be the guide to how
 Tor works, rather than a collection of closed tickets.  (The exception is
 when we're talking about an unresolved issue -- in that case, the open
 ticket is where we should coordinate discussion of getting it diagnosed
 and fixed.)

 Thanks again for the patch!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6997#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list