[tor-bugs] #7592 [Tor]: Return from connection_exit_connect() if we failed to create CONNECTED payload

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Nov 30 00:26:21 UTC 2012


#7592: Return from connection_exit_connect() if we failed to create CONNECTED
payload
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 `882b389668067a29bb539d0f5bd5cb2f83b93012` forgets to return from
 `connection_exit_connect()` if `connected_cell_format_payload()` fails:
 https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/connection_edge.c#l2613

 I'm not too familiar with the high-level logic of this code, but this
 looks buggy.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7592>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list