[tor-bugs] #6266 [Tor]: maxmind geoip db is starting to label Tor relays as country "A1"

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 28 14:19:57 UTC 2012


#6266: maxmind geoip db is starting to label Tor relays as country "A1"
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by karsten):

 Replying to [comment:12 nickm]:
 > Looks workable!  I haven't reviewed the python closely, but it seems not
 to do anything insanely risky, and it's not going to get run automatically
 on untrusted input or anything.

 Cool!  (I'm glad for any input to improve my Python coding skills, so if
 you ever find yourself with nothing else to do, or at least with
 everything else being even less exciting, please let me know how I could
 improve this particular piece of Python.  Thanks! :) )

 > I think this can get merged to master.  BUt should the geoip file get
 merged to previous maintained branches?

 Yes, it should.  I based previous geoip file updates on maint-0.2.2.

 I assume we won't ship `deanyonmind.py` and `README.geoip` with the
 maintained branches, will we?  In that case we should probably replace the
 comment in `geoip` with

 {{{
 # Last updated based on November 7 2012 Maxmind GeoLite Country
 # See README.geoip in Git master for details on the conversion.
 }}}

 or

 {{{
 # Last updated based on November 7 2012 Maxmind GeoLite Country
 # Visit the following URL for details on the conversion:
 # https://gitweb.torproject.org/tor.git/blob/HEAD:/src/config/README.geoip
 }}}

 Please let me know what changes I should make to the task-6266 branch.  Of
 course, if those changes are trivial, please feel free to just
 change/squash/rebase that branch yourself.  Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6266#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list