[tor-bugs] #7558 [Stem]: Minor bug in control test

[Tor Bug Tracker & Wiki]

#7558: Minor bug in control test
---------------------+------------------------------------------------------
 Reporter:  eoinof   |          Owner:  atagar
     Type:  defect   |         Status:  new   
 Priority:  trivial  |      Milestone:        
Component:  Stem     |        Version:        
 Keywords:           |         Parent:        
   Points:           |   Actualpoints:        
---------------------+------------------------------------------------------
 I found a minor bug in
 /test/integ/control/controller.py
 def test_enable_feature

 If networking is enabled but not online, then data
 like this can be in orconn_output
 orconn_output == '$590A7A707B0FAFEF93F57FF061303D4415A13045 LAUNCHED'
 This causes the regular expression to fail on line 346

 When properly offline the test is skipped as orconn_output is a blank
 string
 and when fully online the string is
 '$C4C7BF6724E2AA980E4664C04BC264C4AC7D0627~Anonymous CONNECTED\n ...'
 which matches the regular expression

 One way to fix this would be to only apply the regular expression if the
 2nd part of the orconn_output is CONNECTED.
 And add a separate regular expression for the LAUNCHED status, and
 possibly for any other possible strings?

 I encountered this when running in a virtual machine without an internet
 connection.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7558>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online