[tor-bugs] #7428 [Ooni]: Remove utils/onion.py

[Tor Bug Tracker & Wiki]

#7428: Remove utils/onion.py
---------------------+------------------------------------------------------
 Reporter:  hellais  |          Owner:  isis    
     Type:  task     |         Status:  assigned
 Priority:  normal   |      Milestone:          
Component:  Ooni     |        Version:          
 Keywords:           |         Parent:          
   Points:           |   Actualpoints:          
---------------------+------------------------------------------------------
Changes (by isis):

  * status:  new => assigned
  * owner:  hellais => isis


Comment:

 I need to go through the newest version of txtorcon and read the
 changelog. I wrote those functions for two reasons:

   1. They are actually different in subtle but important ways from the
 ones included in txtorcon at the time. For example, txtorcon.start_tor()
 would overwrite any user-set ControlPort, and also would ignore any
 setting of the DataDirectory. The DataDirectory changes got merged into
 upstream, but there were tiny things in several functions which had to be
 different for my purposes. However, meejah is quick to read ours and
 APAF's sources, and so I would not be surprised if my changes are in
 upstream somewhere (there are a few new high-level abstract functions,
 last I checked).
   2. Txtorcon, at least the API portion, is quite stable. However, I did
 not want to deal with a minor change in one of the high-level functions
 forcing me to rewrite the tests (that's starting to get old, I'm sure you
 feel that way too...). So I included them because they were different, and
 I didn't want to deal with changes I just wanted them to do what I wanted
 them to do.

 tl;dr: Yes, I am sure there is now code which is superfluous. I will go
 through and remove those parts.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7428#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online