[tor-bugs] #6156 [TorBrowserButton]: Rate limit hit of check.tpo on 'new identity' in Tor Browser

[Tor Bug Tracker & Wiki]

#6156: Rate limit hit of check.tpo on 'new identity' in Tor Browser
---------------------------------+------------------------------------------
    Reporter:  phobos            |       Owner:  mikeperry          
        Type:  project           |      Status:  closed             
    Priority:  major             |   Milestone:                     
   Component:  TorBrowserButton  |     Version:                     
  Resolution:  fixed             |    Keywords:  SponsorJ tbb-bounty
      Parent:                    |      Points:                     
Actualpoints:                    |  
---------------------------------+------------------------------------------
Changes (by mikeperry):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 This looks good, but the important bit here was the version check and the
 homepage load, not the removal of the new identity version check. I've
 removed the "New Identity" bits of the patch, and merged the rest. I've
 left the limit at 15 minutes. It is a static file after all..

 The actual check.torproject.org *homepage* is probably the big issue in
 terms of load, but let's save that for a new ticket where we replace the
 update notification with some kind of browser UI, and maybe an additional
 ticket where we replace the browser homepage with a local version. I will
 make a new tickets for the update notification which will combine #4238
 and #6096, and a fresh ticket for making a static, local homepage with our
 choice of search engine (at long last).

 Calling this fixed because I think this ticket was rather unclear in the
 first place, and the patch does rate limit the version check, which is
 useful in and of itself.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6156#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online