[tor-bugs] #5482 [BridgeDB]: Annotate and sort the social-network bridge pools by stability and reachability

[Tor Bug Tracker & Wiki]

#5482: Annotate and sort the social-network bridge pools by stability and
reachability
------------------------------+---------------------------------------------
 Reporter:  karsten           |          Owner:  aagbsn      
     Type:  project           |         Status:  needs_review
 Priority:  normal            |      Milestone:              
Component:  BridgeDB          |        Version:              
 Keywords:  SponsorF20121101  |         Parent:              
   Points:                    |   Actualpoints:              
------------------------------+---------------------------------------------
Changes (by aagbsn):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 karsten]:
 > I finished reviewing 2/3 of the #5482 code.  I'm afraid there's a major
 difference between the #4255 code and this code that makes BridgeDB do
 something vastly different than evaluated in the #4255 analysis: the #5482
 code looks at bridge ''server descriptors'' for calculating stability
 metrics, not bridge ''network statuses''.  But bridge server descriptors
 are only published every 12--18 hours, in contrast to bridge network
 statuses that are published every 30 minutes.  Results will vary a lot. --
 Do you think you can change the #5482 code to use information from bridge
 network statuses instead?  There's nothing in bridge server descriptors
 that we even care about for the stability metrics described in #4255.

 Whoops, that slipped my mind. Fixed now.
 >
 > A few minor remarks:
 >  - `db.getBridgeHistory(self.wmtbac).*` in `Bridges.py` should pass
 `self.fingerprint` as parameter, not `self.wmtbac`.

 Thanks!
 >  - `"%Y-%M-%d %H:%m:%S"` has `%M` and `%m` interchanged; see my last
 comment above.
 >  - `weighting_factor = long(19)/long(20)` is always 0.
 >  - In `Stability.py` there are misspelled references to `weighedTime`
 and `allWeighedTimes`.
 >  - `"DELETE * FROM BridgeDescriptors WHERE timestamp > ?"` purges
 descriptors younger than a given timestamp, not older as the comment says.

 I forgot to remove that code, it wasn't used. Fixed.
 >
 > Thanks!

 I also fixed a slew of other bugs in the process of adding more complete
 test cases.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5482#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online