[tor-bugs] #5279 [TorBrowserButton]: Remove toggle-mode specific request observers

[Tor Bug Tracker & Wiki]

#5279: Remove toggle-mode specific request observers
------------------------------+---------------------------------------------
 Reporter:  mikeperry         |          Owner:  mikeperry                    
     Type:  enhancement       |         Status:  new                          
 Priority:  major             |      Milestone:  TorBrowserBundle 2.3.x-stable
Component:  TorBrowserButton  |        Version:                               
 Keywords:  MikePerry201211d  |         Parent:                               
   Points:                    |   Actualpoints:                               
------------------------------+---------------------------------------------

Old description:

> There might be a fair amount of performance overhead wrapped up in the
> multiple request observers in Torbutton. Many of these exist only because
> of hacks needed to safely support toggling and plugin-blocking. We can
> probably improve performance quite a bit by removing them.
>
> Doing so would mean we'd have to more aggressively deprecate Torbutton
> (#3838), which blocks on an autoupdater.

New description:

 There might be a fair amount of performance overhead wrapped up in the
 multiple request observers in Torbutton. Many of these exist only because
 of hacks needed to safely support toggling and plugin-blocking. We can
 probably improve performance quite a bit by removing them.

 This also makes work like #5709/#1506 simpler, as android is rather
 sensitive to observers, and the multiprocess "Electrolysis" model makes
 some of them unreliable anyways.

 See also #5965.

--

Comment(by mikeperry):

 See also #5965, #1506 and #5709. This ticket is on the way to those tree.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5279#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online