[tor-bugs] #7295 [Ooni]: Core tests are broken

[Tor Bug Tracker & Wiki]

#7295: Core tests are broken
----------------------+-----------------------------------------------------
 Reporter:  hellais   |          Owner:  hellais
     Type:  defect    |         Status:  new    
 Priority:  critical  |      Milestone:         
Component:  Ooni      |        Version:         
 Keywords:            |         Parent:         
   Points:            |   Actualpoints:         
----------------------+-----------------------------------------------------

Comment(by isis):

 loadTestsAndOptions was split up into processLegacyTest and
 processNetTest. see https://gitweb.torproject.org/ooni-
 probe.git/commitdiff/743e6f57cf72058a253134cce092aad9ea95379a

 processTest didn't need to be in there, and it was removed a couple days
 ago.

 The actual bug that is blocking everything, and the reason why I keep
 restructuring runner and nettest is because the were not handling the
 creation of a TestCase's Options class, specifically they were not
 handling subOptions at all. This was blocking the bridge reachability
 tests from working.

 It is enough of a nightmare that I'm expected to have ooni working, and be
 expected to keep the bridge tests updated with a complete API change three
 weeks before both deliverables are due. When you said you were thinking of
 changing the API, I knew this would happen and I thought of making the
 bridge tests separate from ooni because I didn't want to deal with fixing
 both. But I really want them to be integrated, and I really want both to
 work. When you change an API, you're supposed to look at its common use
 cases and make sure those don't break. The API change broke all of my
 tests. Now I'm fixing both ooni's API and the bridge reachability tests
 pretty much by myself, and I have completely missed four nights of sleep
 this week. I'm exhausted, I have not been eating, I have not paid any
 attention to any of my friends or family, and I can't handle this much
 more.

 I need my old tests to work, and that means their options being parsed
 correctly. The new ones need to work too. Please, Arturo, will you help me
 fix this?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7295#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online