[tor-bugs] #6733 [Firefox Patch Issues]: Patch Firefox to allow addons to set SOCKS username+password per request

[Tor Bug Tracker & Wiki]

#6733: Patch Firefox to allow addons to set SOCKS username+password per request
----------------------------------+-----------------------------------------
 Reporter:  mikeperry             |          Owner:  ben     
     Type:  enhancement           |         Status:  accepted
 Priority:  major                 |      Milestone:          
Component:  Firefox Patch Issues  |        Version:          
 Keywords:  interview             |         Parent:  #3455   
   Points:                        |   Actualpoints:          
----------------------------------+-----------------------------------------

Comment(by ben):

 The above implements the SOCKS V4 and V5 protocols to send the username
 and (for V5 only) password.

 There are also new prefs "network.proxy.socks_username" and
 "network.proxy.socks_password" to set them to static values to be used for
 all connections. This is not the usecase needed here for Tor, but I assume
 it's useful for other users, and for testing.

 Speaking of testing, I don't know a SOCKS server that supports auth. I
 have tested with OpenSSH "ssh -D 1234 me at proxy", and that works. If I set
 SOCKS V5 and do not specify a username, the connection works and the
 remote site sees the IP address of the proxy. If I set SOCKS V5 and set
 the above username pref, and restart the browser (!), the connection fails
 entirely, presumably because OpenSSH doesn't support the auth method
 "username/password".  If I set SOCKS V4 and set the above username pref,
 and restart the browser, the connection works, presumably because OpenSSH
 ignores the username sent in SOCKS V4 protocol. The two protocols differ a
 lot when it comes to authentication.

 TODO:
 * Test: with a SOCKS V4 and a SOCKS V5 proxy that supports usernames.
 * Per-channel: Find out when exactly to set the username on the channel,
 and test that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6733#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online