[tor-bugs] #5978 [Tor Relay]: Dead code, possible races, in NT service code

[Tor Bug Tracker & Wiki]

#5978: Dead code, possible races, in NT service code
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 So, the nt_service_set_status function does nothing.  (At least, not
 without a subsequent call to SetServiceStatus_fn, which there isn't).

 Also, everything that sets or checks dwCurrentState in ntmain.c needs to
 be checked for race conditions, and to make sure that it isn't missing a
 call to QueryServiceStatus and/or SetServiceStatus.

 (Reported pseudonymously on IRC.  I probably have some details wrong here;
 more investigation will help)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5978>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online