[tor-bugs] #5519 [Vidalia]: Some improvements for torcontrol code (ControlConnection, ControlSocket classes)

[Tor Bug Tracker & Wiki]

#5519: Some improvements for torcontrol code (ControlConnection, ControlSocket
classes)
---------------------+------------------------------------------------------
 Reporter:  sebb     |          Owner:  sebb                
     Type:  task     |         Status:  needs_review        
 Priority:  minor    |      Milestone:                      
Component:  Vidalia  |        Version:  Vidalia: 0.3.1-alpha
 Keywords:           |         Parent:                      
   Points:           |   Actualpoints:                      
---------------------+------------------------------------------------------
Changes (by sebb):

  * status:  needs_revision => needs_review


Comment:

 first commit for infinite loop fix:
 https://github.com/sebthestampede/vidalia/commit/6205ea37dc834390f4a21be8ad75939e7827064a
 (same branch name)
 what about second "changes" file name, for the ControlSocket cleanup ? the
 ticket number is the same

 I never saw that bug with PROTOCOLINFO, but your fix looks ok to me.
 Another thing is, shouldn't we remove deleted RecvWaiter object from the
 _recvQueue ? Now it looks like a dangling pointer stays in there (after
 "delete w;" line). And call "delete" on object returned by
 _recvQueue.dequeue();

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5519#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online